Skip to content

cleanup#4439

Merged
frett merged 7 commits into
developfrom
cleanup
May 28, 2026
Merged

cleanup#4439
frett merged 7 commits into
developfrom
cleanup

Conversation

@frett

@frett frett commented May 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

frett and others added 6 commits May 27, 2026 11:04
… in tool activities

Replace setVariable(BR.manifest/loadingProgress/loadingState) calls in BaseToolActivity
and its subclasses with typed property access on the binding object, eliminating the
dependency on the generated BR class for the main build variant.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… in ShareablesAdapter

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… in ShareAppsAdapter

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… in OtherActionsAdapter

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 27.77778% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.23%. Comparing base (d3b58e6) to head (b4df279).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ru/godtools/base/tool/ui/share/ShareAppsAdapter.kt 0.00% 9 Missing ⚠️
.../cru/godtools/article/aem/ui/AemArticleActivity.kt 0.00% 4 Missing ⚠️
...odtools/base/tool/ui/settings/ShareablesAdapter.kt 0.00% 4 Missing ⚠️
...tool/ui/shareable/model/ShareableImageShareItem.kt 0.00% 3 Missing ⚠️
...cru/godtools/tract/ui/share/model/LiveShareItem.kt 0.00% 3 Missing ⚠️
...godtools/base/tool/ui/share/OtherActionsAdapter.kt 0.00% 2 Missing ⚠️
...cru/godtools/base/tool/ui/share/model/ShareItem.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4439      +/-   ##
===========================================
- Coverage    52.23%   52.23%   -0.01%     
===========================================
  Files          457      457              
  Lines        12170    12193      +23     
  Branches      2109     2118       +9     
===========================================
+ Hits          6357     6369      +12     
- Misses        5192     5202      +10     
- Partials       621      622       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@frett frett merged commit 334fa73 into develop May 28, 2026
13 checks passed
@frett frett deleted the cleanup branch May 28, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant